Handle Duplicate decision numbers #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t11omas
force-pushed
the
feature/cdms-342
branch
from
25c7c78 to
5c3b803
Compare
added 8 commits
February 11, 2025 07:42
…ion to avoid duplicate decision numbers
# Conflicts: # Btms.Business/Services/Decisions/DecisionService.cs
t11omas
changed the title
|
|
tstesyn
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address the duplicate decision numbers. Its a really tough issue to reproduce locally during integration tests, and I have been unsuccessful in doing so.
This Pr changes how decisions are saved within BTMS, previously it was done within the DecisionConsumer, but now its done as part of the Notification/Movement consumers, and the save happens within the transaction. This should ensure that the count of decision, and the decision number are unique.
To further enforce the decision numbers are unique, a compound index has been added on the EntryReference plus DecisionNumber, which will ensure at the DB level decision numbers are unique.
This PR also adds in audit entries for skipped records to help track when records are skipped due to be an earlier version